Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses parallel construction in the COI section #659

Merged
merged 6 commits into from
Apr 26, 2023
Merged

Uses parallel construction in the COI section #659

merged 6 commits into from
Apr 26, 2023

Conversation

eliocamp
Copy link
Contributor

This small PR changes the wording in the COI section so that every bulletpoint follows the same parallel construction.

Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eliocamp. Please ping again once you've accepted those minor suggestions (with modification if you like), and we'll happily approve.

softwarereview_policies.Rmd Outdated Show resolved Hide resolved
softwarereview_policies.Rmd Outdated Show resolved Hide resolved
softwarereview_policies.Rmd Outdated Show resolved Hide resolved
softwarereview_policies.Rmd Outdated Show resolved Hide resolved
eliocamp and others added 4 commits April 24, 2023 17:32
Co-authored-by: mark padgham <mark.padgham@email.com>
Co-authored-by: mark padgham <mark.padgham@email.com>
Co-authored-by: mark padgham <mark.padgham@email.com>
Co-authored-by: mark padgham <mark.padgham@email.com>
@eliocamp
Copy link
Contributor Author

@mpadge There you go, all accepted. :)

@mpadge
Copy link
Member

mpadge commented Apr 25, 2023

One more request @eliocamp: could you please add a line desribing these changes to the changelog as well? Let us know, and then I'll approve and merge. Thanks

@eliocamp
Copy link
Contributor Author

Ready! Let me know if it looks good.

@mpadge mpadge self-requested a review April 26, 2023 07:43
Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@mpadge mpadge merged commit bca7611 into ropensci:main Apr 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants