Skip to content

Commit

Permalink
Fix #786
Browse files Browse the repository at this point in the history
  • Loading branch information
wlandau-lilly committed Mar 19, 2019
1 parent cab7b4d commit d1fceb8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions NEWS.md
Expand Up @@ -15,6 +15,7 @@
- Hide node labels by default and render the arrows behind the nodes.
- Print an informative error message when the user supplies a `drake` plan to the `config` argument of a function.
- By default, use gray arrows and a black-and-white background with no gridlines.
- For the `map()` and `cross()` transformations in the DSL, prevent the [accidental sorting of targets by name](https://github.com/ropensci/drake/issues/786). Needed `merge(sort = FALSE)` in `dsl_left_outer_join()`.


# Version 7.0.0
Expand Down
4 changes: 2 additions & 2 deletions R/api-dsl.R
Expand Up @@ -359,7 +359,7 @@ dsl_revdeps.map <- function(transform) {
tag_out(transform)
)
}

dsl_revdeps.cross <- dsl_revdeps.map

dsl_revdeps.combine <- function(transform) {
Expand Down Expand Up @@ -524,7 +524,7 @@ dsl_left_outer_join <- function(x, y) {
y <- y[!duplicated(y[, by, drop = FALSE]),, drop = FALSE] # nolint
# Is merge() a performance bottleneck?
# Need to profile.
out <- merge(x = x, y = y, by = by, all.x = TRUE)
out <- merge(x = x, y = y, by = by, all.x = TRUE, sort = FALSE)
out[, union(colnames(x), colnames(y)), drop = FALSE]
}

Expand Down

0 comments on commit d1fceb8

Please sign in to comment.