Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drake_plan() should look for duplicate targets #305

Closed
krlmlr opened this issue Mar 7, 2018 · 1 comment · Fixed by #307
Closed

drake_plan() should look for duplicate targets #305

krlmlr opened this issue Mar 7, 2018 · 1 comment · Fixed by #307

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented Mar 7, 2018

We still need to double-check for duplicates during make(), keys in tibbles will help (tidyverse/dplyr#1792).

From #304 (comment), CC @rkrug.

drake::drake_plan(a = 1, a = 2)
#> # A tibble: 2 x 2
#>   target command
#>   <chr>  <chr>  
#> 1 a      1      
#> 2 a      2

Created on 2018-03-07 by the reprex package (v0.2.0).

@wlandau-lilly
Copy link
Collaborator

Agreed. I'm a bit inundated at the moment, but this should be easy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants