Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log progress in make() and r_make() #889

Closed
2 tasks done
wlandau opened this issue May 27, 2019 · 4 comments
Closed
2 tasks done

Only log progress in make() and r_make() #889

wlandau opened this issue May 27, 2019 · 4 comments

Comments

@wlandau
Copy link
Member

wlandau commented May 27, 2019

Prework

Description

This affects the log_progress and console_log_file arguments.

@wlandau
Copy link
Member Author

wlandau commented May 27, 2019

Should change the default value of log_progress to TRUE in drake_config().

@wlandau
Copy link
Member Author

wlandau commented May 27, 2019

Reason for this issue: ensure r_make() logs progress and r_vis_drake_graph() does not break the log.

@wlandau
Copy link
Member Author

wlandau commented May 28, 2019

On second thought: let's continue to allow other functions to write to the console log file as long as we clearly indicate the function that is running and add a line break between function calls where appropriate.

@wlandau
Copy link
Member Author

wlandau commented May 28, 2019

Never mind the line breaks, that gets too messy. Let's add the PID to the log instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant