Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate plot_graph and render_graph(), use different names #151

Merged
merged 6 commits into from Nov 13, 2017
Merged

Deprecate plot_graph and render_graph(), use different names #151

merged 6 commits into from Nov 13, 2017

Conversation

wlandau
Copy link
Collaborator

@wlandau wlandau commented Nov 13, 2017

Use vis_drake_graph() and render_drake_graph() instead. Lots of people plot and render graphs, so I thought these name changes would be particularly important for #147 and ropensci/software-review#156

@lintr-bot
Copy link

R/deprecate.R:517:25: style: Variable and function names should be all lowercase.

navigationButtons = navigationButtons,
                        ^~~~~~~~~~~~~~~~~

@codecov-io
Copy link

codecov-io commented Nov 13, 2017

Codecov Report

Merging #151 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #151   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          57     57           
  Lines        3509   3593   +84     
=====================================
+ Hits         3509   3593   +84
Impacted Files Coverage Δ
R/make.R 100% <ø> (ø) ⬆️
R/read.R 100% <ø> (ø) ⬆️
R/basic_example.R 100% <ø> (ø) ⬆️
R/color.R 100% <ø> (ø) ⬆️
R/workplan.R 100% <ø> (ø) ⬆️
R/parallel_ui.R 100% <ø> (ø) ⬆️
R/dataframes_graph.R 100% <ø> (ø) ⬆️
R/dataframes_graph_utils.R 100% <ø> (ø) ⬆️
R/outdated.R 100% <ø> (ø) ⬆️
R/deprecate.R 100% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06895ce...03338c1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants