Fix #320: ignore the magrittr dot (.)
#321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 66 66
Lines 5176 5177 +1
=====================================
+ Hits 5176 5177 +1
Continue to review full report at Codecov.
|
AlexAxthelm
approved these changes
Mar 14, 2018
|
Thanks, Alex! Kirill, free to chime in when it is convenient for you. |
krlmlr
reviewed
Mar 16, 2018
| @@ -357,14 +357,14 @@ find_globals <- function(expr){ | |||
| } | |||
| # Warning: In collector$results(reset = reset) : | |||
| # partial argument match of 'reset' to 'resetState' | |||
|
|
|||
| suppressWarnings(inputs <- CodeDepends::getInputs(expr)) | |||
| base::union( | |||
| inputs@inputs, | |||
| names(inputs@functions) | |||
| ) %>% | |||
| setdiff(y = c(formals, drake_fn_patterns)) %>% | |||
There was a problem hiding this comment.
Maybe just add the dot up there?
There was a problem hiding this comment.
Good catch. See 3ef462e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From #320 and duncantl/CodeDepends#26, the
magrittrdot (.) is sometimes treated as a dependency even when it is just a placeholder symbol. Detection depends on the context of the rest of the code in the static analysis. In the case ofdrake, this is a bit mysterious, and the behavior onmastermay invalidate targets unpredictably.This PR forces (
.) to never be a dependency, even when the user references it outside the intended tidyverse context. So if the user tries to reference (.) in a command as an ordinary variable,drakewill still ignore it. That is fine with me because it is almost never something we should expect users to do and this PR documents it in the `caution.Rmd vignette. I think we should maximize consistency and minimize surprises.@AlexAxthelm, I wanted to add you as a reviewer for this PR, but I cannot request anyone outside the list. May I add you as a collaborator in the repo settings for subsequent PRs?
GitHub issues fixed
Checklist
drake's code of conduct, and I agree to follow its rules.testthatunit tests totests/testthatto confirm that any new features or functionality work correctly.devtools::check()