Update package to support EIA API v2 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for function docs
…om tests; rework function docs with markdown notation
…PI is a self-discoverable directory
leonawicz
commented
Oct 30, 2023
tests/testthat/test-key.R
Outdated
| @@ -1,3 +1,14 @@ | |||
| test_that("EIA key availability startup message works as expected", { | |||
There was a problem hiding this comment.
I don't know if we need to test this one. The logic is good! But this kind of test may not be reliable in a variety of environments and the detaching and attaching of the package being tested is not common practice. We don't need to really test the startup up message. Definitely do not want to add devtools as any kind of package requirement. It brings in like a million other packages. I'd say just remove this test. If you want, we can include a covr file exclusion for zzz.R. (Comment updated)
…e number is unlikely to change any time soon for this context.
…a_get_key(). Anyhow, this line is unlikely to have to run in practice. Correct comment in example.
leonawicz
commented
Oct 30, 2023
tests/testthat/test-dirs.R
Outdated
| @@ -25,11 +25,11 @@ test_that("directory functions returns as expected", { | |||
| expect_s3_class(x, "tbl_df") | |||
| expect_equal(dim(x), c(6, 3)) | |||
|
|
|||
| msg <- paste0( | |||
| suppressMessages(msg <- message( | |||
There was a problem hiding this comment.
You don't need to do that. You just need to escape the parentheses in your expected string with \( and \).
…an message that includes parentheses.
… other non-CRAN environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full package refactor due to fundamental changes to EIA API from version 1 to version 2.
Plus various other updates.