You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm so used to this that I forget that it might be confusing to new users. EML::write_xml returns NULL when you save to disk because of the behavior of emld's as_xml method returns the raw result from xml2::write_xml which returns invisible(). One of our team caught this over on NCEAS/datateam-training#229.
The relevant code is:
## Serialize to file if desiredif(!is.null(file)){
xml2::write_xml(xml, file)
} else {
xml
}
I wasn't sure what the best return type is here. The readr functions, which are common to most users, seem to return the input (to support piping). This method currently returns either an xml_document or NULL. Maybe the best thing is just to wrap the write_xml in invisible() and avoid making any big changes to the return type.
I'm so used to this that I forget that it might be confusing to new users.
EML::write_xml
returnsNULL
when you save to disk because of the behavior ofemld
'sas_xml
method returns the raw result fromxml2::write_xml
which returnsinvisible()
. One of our team caught this over on NCEAS/datateam-training#229.The relevant code is:
I wasn't sure what the best return type is here. The readr functions, which are common to most users, seem to return the input (to support piping). This method currently returns either an
xml_document
orNULL
. Maybe the best thing is just to wrap thewrite_xml
ininvisible()
and avoid making any big changes to the return type.Thoughts @cboettig?
The text was updated successfully, but these errors were encountered: