Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Handle integers in input files #25

Closed
HaoZeke opened this issue Oct 22, 2023 · 0 comments
Closed

ENH: Handle integers in input files #25

HaoZeke opened this issue Oct 22, 2023 · 0 comments
Assignees
@HaoZeke
Labels
enhancement New feature or request ropensci-review Issues related to the ROpenSci review
Milestone
v1.0.0

Comments

@HaoZeke
Copy link
Member

HaoZeke commented Oct 22, 2023

vec_to_fmm(1L, "vector.mtx")
#> Error: Invalid input type, expected 'double' actual 'integer'

However, I was wondering if it could actually accept integers as well?

First noted here: ropensci/software-review#606 (comment).
@HaoZeke HaoZeke added enhancement New feature or request ropensci-review Issues related to the ROpenSci review labels Oct 22, 2023
@HaoZeke HaoZeke added this to the v1.0.0 milestone Oct 22, 2023
@HaoZeke HaoZeke self-assigned this Oct 22, 2023
HaoZeke added a commit that referenced this issue Oct 23, 2023
@HaoZeke
MAINT: Add auto-gen data for integer vector inputs
bc92d97 
Part of gh-25
HaoZeke added a commit that referenced this issue Oct 23, 2023
@HaoZeke
ENH: Add support for integer matrices
024898a 
Also addresses #25.
@HaoZeke HaoZeke mentioned this issue Oct 24, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HaoZeke HaoZeke

Labels
enhancement New feature or request ropensci-review Issues related to the ROpenSci review
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@HaoZeke