Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Better error messages for sparse_to_fmm #27

Closed
HaoZeke opened this issue Oct 22, 2023 · 1 comment
Closed

MAINT: Better error messages for sparse_to_fmm #27

HaoZeke opened this issue Oct 22, 2023 · 1 comment
Labels
maintenance ropensci-review Issues related to the ROpenSci review
Milestone
v1.0.0

Comments

@HaoZeke
Copy link
Member

HaoZeke commented Oct 22, 2023

improve error message?

mat <- matrix(c(1, 2, 3, 4), nrow = 2)
sparse_to_fmm(mat, "matrix.mtx")
#> Error: Invalid input type, expected 'double' actual 'NULL'

First noted here: ropensci/software-review#606 (comment).

The wrong function is called but the error message is confusing.
@HaoZeke HaoZeke added ropensci-review Issues related to the ROpenSci review maintenance labels Oct 22, 2023
@HaoZeke HaoZeke added this to the v1.0.0 milestone Oct 22, 2023
@HaoZeke
Copy link
Member Author

HaoZeke commented Oct 23, 2023

Actually users should not be calling this function either. write_fmm is meant to be used.

@HaoZeke HaoZeke closed this as completed Oct 23, 2023
@HaoZeke HaoZeke mentioned this issue Oct 24, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance ropensci-review Issues related to the ROpenSci review
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@HaoZeke