fixed bug with multiple IndicatorIDs and ProfileIDs in fingertips_dat…

…a() - closes issue #63
ropensci · Feb 13, 2019 · 71bb9bd · 71bb9bd
1 parent 1b9877f
commit 71bb9bd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,8 @@
 # fingertipsR 0.2.0.9000
+
  * `deprivation_decile()` for `AreaTypeID = 7` (General Practice) now only contains 2015 deprivation deciles. 2010 to 2012 have been removed
 
+* bug fix around entering vectors of `IndicatorID`s and `ProfileID`s into `fingertips_data()` function
 
 # fingertipsR 0.2.0 (12/11/2018)
 

diff --git a/R/retrieve_data.R b/R/retrieve_data.R
@@ -10,12 +10,18 @@ retrieve_indicator <- function(IndicatorIDs, ProfileIDs, ChildAreaTypeIDs, Paren
         } else {
                 profileID_bit <- "&profile_id=%s"
         }
-        fd <- expand.grid(IndicatorIDs = IndicatorIDs,
-                             ProfileIDs = ProfileIDs,
-                             ChildAreaTypeIDs = ChildAreaTypeIDs,
-                             ParentAreaTypeIDs = ParentAreaTypeIDs,
-                             path = path,
-                             profileID_bit = profileID_bit) %>%
+        # fd <- expand.grid(IndicatorIDs = IndicatorIDs,
+        #                      ProfileIDs = ProfileIDs,
+        #                      ChildAreaTypeIDs = ChildAreaTypeIDs,
+        #                      ParentAreaTypeIDs = ParentAreaTypeIDs,
+        #                      path = path,
+        #                      profileID_bit = profileID_bit) %>%
+        fd <- data.frame(IndicatorIDs = IndicatorIDs,
+                         ProfileIDs = ProfileIDs,
+                         ChildAreaTypeIDs = ChildAreaTypeIDs,
+                         ParentAreaTypeIDs = ParentAreaTypeIDs,
+                         path = path,
+                         profileID_bit = profileID_bit) %>%
                 unique()
 
         set_config(config(ssl_verifypeer = 0L))