Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_geojson #29

Merged
merged 2 commits into from Oct 27, 2017
Merged

to_geojson #29

merged 2 commits into from Oct 27, 2017

Conversation

ateucher
Copy link
Member

A general function to detect the type of geojson object and automatically add the appropriate class using one of:

point()
linestring()
polygon()
multipoint()
multilinestring()
multipolygon()
feature()
featurecollection()
geometrycollection()

Address #28.

@codecov-io
Copy link

codecov-io commented Oct 26, 2017

Codecov Report

Merging #29 into master will increase coverage by 13.82%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #29       +/-   ##
==========================================
+ Coverage   54.87%   68.7%   +13.82%     
==========================================
  Files          24      24               
  Lines         492     508       +16     
==========================================
+ Hits          270     349       +79     
+ Misses        222     159       -63
Impacted Files Coverage Δ
R/as.geojson.R 68.57% <100%> (+53.75%) ⬆️
R/zzz.R 70.37% <0%> (+3.7%) ⬆️
R/feature.R 69.23% <0%> (+3.84%) ⬆️
R/featurecollection.R 61.9% <0%> (+61.9%) ⬆️
R/geometrycollection.R 71.42% <0%> (+71.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 895d8e9...fd951cc. Read the comment docs.

@sckott
Copy link
Contributor

sckott commented Oct 27, 2017

nooiiice, LGTM

@sckott sckott merged commit b7950d1 into ropensci:master Oct 27, 2017
@sckott sckott added this to the v0.2 milestone Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants