Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle (authenticating) proxy setting #395

Open
espinielli opened this issue Aug 3, 2019 · 0 comments
Open

Handle (authenticating) proxy setting #395

espinielli opened this issue Aug 3, 2019 · 0 comments

Comments

@espinielli
Copy link

It looks like git2r is not handling PROXY configuration as from libgit2 API:
(at least) two examples are described in #269 as symptoms of this deficiency.

For example git_remote_fetch calls in git2r code can have a git_proxy_options as part of its git_fetch_options argument in order to handle PROXY settings but that is not (yet) done and make certain use scenarios fail.

To summarize, it looks like there is the need to properly fill the git_proxy_options in git_fetch_options (passed in 3 function calls in libgit2: git_remote_fetch, git_remote_download and git_fetch_options_init) or directly (passed in 2 function calls in libgit2: git_remote_connect and git_proxy_options_init) to make git2r work behind an authenticating PROXY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant