Enable argument 'all' to commit multiple modified (or deleted) files. #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed the behavior that setting the argument
all = TRUE
forcommit
only commits one tracked file instead of all tracked files. The unit tests only test for one modified file or one deleted file. I think the issue is from line #155 in commit.r.s$unstaged
is a named list, thus passings$unstaged$modified
tolapply
is only passing one element of the list. Here's a small example to illustrate:I updated
commit
so that it will iterate over all tracked files and also added some unit tests. I was able to runmake check
successfully with R 3.4.0 on Ubuntu 16.10. Please let me know if you would like me to make any modifications.