Fix tests #23
Merged
Fix tests #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRAN maintainers notified me about check errors:
https://cran.r-project.org/web/checks/check_results_hoardr.html
I'm not 100% sure what caused the issue, it seems
unlink()did not delete the cache directory when I ran tests usingdevtools::test(). Strange behaviour though,dir.exists(cache_dir)returned FALSE, butfile.exists(cache_dir)returned TRUE.This PR updates cache dir full path in
test-HoardClient.Rline 35 fromtempdir()to a subdirectory oftempdir()which fixes the issue. I also upgraded testthat to edition 3.I'll merge this PR and issue a patch release to keep the package from being archived on CRAN.