Handling a vector of dictionaries in get_dict

[meztez]

In get_dict :

• modified file.exists condition check to avoid length > 1 warning
• modified find_in_dicpath call to handle multiple unfound dict

[codecov-io]

Codecov Report

Merging #37 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   39.81%   39.82%   +<.01%     
==========================================
  Files          28       28              
  Lines        8359     8360       +1     
==========================================
+ Hits         3328     3329       +1     
  Misses       5031     5031

Impacted Files	Coverage Δ
R/hunspell.R	81.81% <100%> (+0.18%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e57e6...da358a9. Read the comment docs.

[jeroen]

Can you include example code of how you use this?

[meztez]

I use the code below

library(hunspell)
library(curl)

extractdict <- function(url) {
  temp <- tempfile()
  curl_download(url, temp)
  dicts <- grep("\\.aff?|\\.dic?", unzip(temp, list = TRUE)$Name, value = TRUE)
  unzip(temp, files = dicts, overwrite = TRUE, junkpaths = TRUE, exdir = "dict")
  unlink(temp)
  return(paste0("./dict/", basename(grep("\\.dic", dicts, value = TRUE))))
}

dict_fr <- extractdict("https://addons.mozilla.org/firefox/downloads/file/1163947/french_spelling_dictionary-6.3.1webext.xpi")
dict_en <- extractdict("https://addons.mozilla.org/firefox/downloads/file/1163920/canadian_english_dictionary-3.0.6.1webext.xpi")

sc <- hunspell("some text", dict = c(dict_fr, dict_en))

Other test I've made and why I used sapply

get_dict(c(dict_fr, dict_en, "en_US", "poison.dic"))

[meztez]

Don't merge yet, it works but the input from print(dict) looks like garbage. Sorry

[meztez]

I'm closing it, it is causing a bunch of weird behaviors mostly for the affix part. This is not ready.