Skip to content

Commit

Permalink
Fix ASAN problem
Browse files Browse the repository at this point in the history
  • Loading branch information
@jeroen
jeroen committed Jul 27, 2016
1 parent ee67852 commit 01a6dce
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/jqr.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ typedef boost::shared_ptr<jv_parser> jv_parser_ptr;

void jqr_err_cb(void *, jv x) {
const char *msg = jv_string_value(x);
jv_free(x); // I think this is our responsibility.
//jv_free(x); // Causes segfaults valgrand / ASAN
Rcpp::stop(msg);
}

Expand Down

3 comments on commit 01a6dce

@richfitz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that we leak a bit then?

@jeroen
Copy link
Member Author

@jeroen jeroen commented on 01a6dce Jul 27, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not here, according to asan/valgrind this one already is free'd. But we leak on a bunch of other places anyway :-)

@richfitz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good :)

Please sign in to comment.