adapt ajv validator to meta-schema version #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion - in js, provide new functions global.ajv(), global.ajv_04(), and global.get_meta_schema() - global.ajv() used for draft-06, draft-07 - global.ajv_04 used for draft-04, removes keywords - in R, call js to determine the meta-schema version, then call the associated js validator - updates tests (uncomments tests) - updates Roxygen version
Closed
|
This looks good to me! Thanks @ijlyttle for solving the puzzle. |
richfitz
added a commit
that referenced
this pull request
Jul 31, 2019
This should have been added to the in.js file rather than directly to the bundle file - we should document this better
richfitz
added a commit
that referenced
this pull request
Aug 1, 2019
This should have been added to the in.js file rather than directly to the bundle file - we should document this better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #2, to provide ajv-constructor calls according to the meta-schema "draft" version:
global.ajv(),global.ajv_04(), andglobal.get_meta_schema()global.ajv()used for draft-06, draft-07global.ajv_04()used for draft-04, removes keywordsAll the newly-uncommented tests pass.