Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct Non-Numeric argument errors and Update gh-actions for compatibility #39

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: Correct Non-Numeric argument errors and Update gh-actions for compatibility #39

wants to merge 5 commits into from

Conversation

esloch
Copy link

@esloch esloch commented May 18, 2024 •
edited
Loading

Description:

This pull request addresses multiple issues within the medRxivr package, ensuring both the functionality of the R functions and the compatibility of the GitHub Actions workflow.

Changes:

  1. mx_crosscheck Function:

    • Added numeric conversion for reference and extracted variables.
    • Included checks for NA values to prevent non-numeric argument errors.

  2. mx_api_content Function:

    • Added numeric conversion for the count variable.
    • Included check for NA values to prevent non-numeric argument errors.
    • Improved progress bar initialization formatting.
    • Fixed minor formatting issues and typos in the function.

  3. GitHub Actions Workflow:

    • Update system dependency installation for Linux.
    • Implement caching of R packages for Linux and macOS.
    • Include missing package installations specifically for Windows.
    • Update the workflow to handle OS-specific package installation and checks.
    • Update r-lib/actions to version v2 to resolve the action download error.

References:

@esloch esloch changed the title Fix Non-Numeric argument errors in mx_api_content and mx_crosscheck functions fix: Correct Non-Numeric argument errors in mx_api_content and mx_crosscheck functions May 18, 2024
@esloch esloch changed the title fix: Correct Non-Numeric argument errors in mx_api_content and mx_crosscheck functions fix: Correct Non-Numeric argument errors and Update gh-actions for compatibility May 20, 2024
@esloch esloch mentioned this pull request May 20, 2024
Closed
@esloch esloch marked this pull request as ready for review May 20, 2024 14:32
@xmnlab
Copy link

xmnlab commented May 21, 2024

hey everyone! just checking if we can move this forward.
this tried to move forward the PR started 3 weeks ago #36

also, we would like to check if this package is still maintained or not, if there is plans to keep it maintained, etc
as we are using that in our pipeline, we can maybe help in this maintenance. if necessary.

thanks!

@yabellini
Copy link
Member

Hello, @esloch and @xmnlab. We are reaching out to the maintainer through other means and will get back to you. Thanks for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@esloch @xmnlab @yabellini