Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional attribution information #48

Closed
mbojan opened this issue Oct 5, 2017 · 6 comments
Closed

Additional attribution information #48

mbojan opened this issue Oct 5, 2017 · 6 comments
Milestone

Comments

@mbojan
Copy link
Member

mbojan commented Oct 5, 2017

Hi @sckott , I have the following question: would you have anything against including the information about the package authors in the oai-package.R file? That would allow me to insert there the grant citation that was supporting my contributions to this package. I imagine a section "Authors" with a bullet for each author and mine as something like "Michal Bojanowski, supported by NCN grant 2012/07/D/HS6/01971". This could be also in README. Or perhaps you'll have a different suggestion.

Bit more background: I used the oai package to collect data for research purposes for my project http://recon.icm.edu.pl . Now I am in for writing the final report and listing various contributions made. I wanted to include my work on extending oai (dumpers etc.) for data collection purposes. This will have no copyright/licensing consequences whatsoever.

What do you think?

@sckott
Copy link
Collaborator

sckott commented Oct 6, 2017

sounds good to me. in the package level man file sounds good, and in readme as well. There may be something we can put in a structured way in the DESCRIPTION file - i'll ask about that.

@mbojan
Copy link
Member Author

mbojan commented Oct 6, 2017

Great thanks

@mbojan
Copy link
Member Author

mbojan commented Oct 6, 2017

structured way in the DESCRIPTION file - i'll ask about that.

person() has a comment argument, perhaps this would be the right place...

@mbojan
Copy link
Member Author

mbojan commented Oct 6, 2017

not bad actually:

person("michal", "bojanowski", role="aut", comment="Supported by NCN xxx/xxx/xxx/xxx")
## [1] "michal bojanowski [aut] (Supported by NCN xxx/xxx/xxx/xxx)"

@sckott
Copy link
Collaborator

sckott commented Oct 6, 2017

nice, sounds good to me.

also, found some instances of grant mentioned in DESCRIPTION files on github https://github.com/search?utf8=%E2%9C%93&q=user%3Acran+grant+filename%3ADESCRIPTION&type=Code

@mbojan
Copy link
Member Author

mbojan commented Oct 6, 2017

Good. I'll submit a PR soon.

mbojan added a commit to mbojan/oai that referenced this issue Oct 7, 2017
mbojan added a commit to mbojan/oai that referenced this issue Oct 7, 2017
@sckott sckott added this to the v0.3 milestone Sep 6, 2019
@sckott sckott closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants