Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of pb_list() and other changes #65

Merged
merged 29 commits into from
Apr 26, 2022
Merged

Conversation

tanho63
Copy link
Collaborator

@tanho63 tanho63 commented Apr 25, 2022

TODO:

  • make all tests pass
  • update news file
  • audit rest of code for print messaging improvements

pb_releases() ONLY returns a list of the releases available in repo.
pb_info now checks for tag specifications and ONLY returns assets for
the specified tags (if specified). Also pb_info no longer asks about
creating new releases, nor does it warn about missing releases.

also, memoise should happen in .onLoad()
Add ask to create new release and rewrite messaging with {cli}
@tanho63 tanho63 marked this pull request as ready for review April 26, 2022 03:42
@tanho63
Copy link
Collaborator Author

tanho63 commented Apr 26, 2022

Okay, so this PR got a little bit away from me and does quite a lot, but I think it takes care of a lot of the outstanding issues I noticed when I was working through it.

Please let me know if you see any issues or have any questions!

R/zzz.R Show resolved Hide resolved
Copy link
Member

@cboettig cboettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Thanks for the excellent work here! Will cut a new CRAN release to ship these changes shortly.

@cboettig cboettig merged commit 42eba8c into ropensci:master Apr 26, 2022
@tanho63
Copy link
Collaborator Author

tanho63 commented Apr 26, 2022

Awesome! Let me know if there's anything I can help with re: CRAN release

@tanho63 tanho63 deleted the tandev branch April 26, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants