-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of pb_list() and other changes #65
Conversation
pb_releases() ONLY returns a list of the releases available in repo. pb_info now checks for tag specifications and ONLY returns assets for the specified tags (if specified). Also pb_info no longer asks about creating new releases, nor does it warn about missing releases. also, memoise should happen in .onLoad()
Add ask to create new release and rewrite messaging with {cli}
Okay, so this PR got a little bit away from me and does quite a lot, but I think it takes care of a lot of the outstanding issues I noticed when I was working through it. Please let me know if you see any issues or have any questions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me. Thanks for the excellent work here! Will cut a new CRAN release to ship these changes shortly.
Awesome! Let me know if there's anything I can help with re: CRAN release |
TODO: