Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle latest upload #86

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Handle latest upload #86

merged 3 commits into from
Jul 20, 2022

Conversation

tanho63
Copy link
Collaborator

@tanho63 tanho63 commented Jul 20, 2022

This should hopefully help resolve #75 by adding handling for "latest" tag in pb_upload - looks for release named "latest" and otherwise uses the first release returned by pb_releases()

A tad mistimed since it went to CRAN yesterday, but alas, it’ll work for next version!

TODO:

  • write a test for the default/latest tag...and try not to break the other tests while doing it...

@tanho63
Copy link
Collaborator Author

tanho63 commented Jul 20, 2022

@noamross does this branch (ropensci/handle-latest-upload) resolve it?

@noamross
Copy link

Yes, it does!

@tanho63 tanho63 requested a review from cboettig July 20, 2022 16:51
@cboettig
Copy link
Member

🎉

@cboettig cboettig merged commit 8f341b7 into master Jul 20, 2022
@cboettig cboettig deleted the handle-latest-upload branch July 20, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected recurring error message
3 participants