Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA for codecov #87

Merged
merged 5 commits into from
Jul 25, 2022
Merged

Add GHA for codecov #87

merged 5 commits into from
Jul 25, 2022

Conversation

tanho63
Copy link
Collaborator

@tanho63 tanho63 commented Jul 24, 2022

Noticed the codecov was out of date, probably last tested with travis or something. I don't have access to the ropensci codecov token, but the GHA should work once the correct token is uploaded.

Also bugfixed pb_info handling of no releases and added testing for no releases found + file not found on downloads.

Coverage looks to be around 85% which is pretty good! Not currently testing for http errors.

@tanho63 tanho63 requested a review from cboettig July 24, 2022 12:17
@tanho63
Copy link
Collaborator Author

tanho63 commented Jul 24, 2022

GHA checks are passing (some need a retry mostly based on http errors, but that seems par for the course.)

Copy link
Member

@cboettig cboettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@cboettig cboettig merged commit 4f7077a into master Jul 25, 2022
@cboettig cboettig deleted the codecov-update branch July 25, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants