Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pb_list() respect option "piggyback.verbose" #91

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

mrcaseb
Copy link
Contributor

@mrcaseb mrcaseb commented Aug 5, 2022

This PR fixes #90

The internal function get_release_assets now calls gh::gh() with the argument .progress.

@mrcaseb
Copy link
Contributor Author

mrcaseb commented Aug 5, 2022

Running the example from #90 with this PR results in this

options(piggyback.verbose = FALSE)
assets <- piggyback::pb_list(repo = "nflverse/nflverse-data")

Created on 2022-08-05 by the reprex package (v2.0.1)

Copy link
Collaborator

@tanho63 tanho63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tanho63 tanho63 merged commit aa6e3f8 into ropensci:master Aug 5, 2022
@mrcaseb mrcaseb deleted the pblist-respect-verbose-option branch August 6, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pb_list() doesn't respect the option piggyback.verbose
2 participants