New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of an `unzip` argument to optionally not unzip downloads #125

Open

Aariq wants to merge 3 commits into ropensci:master from Aariq:unzip-eric

Aariq commented Apr 1, 2024

This is a draft addressing #124. Things I'm still uncertain about, but would be happy to add to this PR:

How this should/shouldn't interact with process_zip() that deals with pre-1980 files
Where to put a test for this (seems like tests in test-prism_webservice.R purposefully don't hit the API)
Would it be helpful to document how to read in data from a .zip without unzipping? E.g. in an example or short vignette?

Aariq added 3 commits

April 1, 2024 11:15


          add unzip argument

0ec26b7


          add unzip arg

2e3b711


          skip re-downloading when only zip file is present

c205078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment