Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give a little more guidance in setting base URL #257

Closed
jeanetteclark opened this issue Apr 26, 2022 · 2 comments
Closed

give a little more guidance in setting base URL #257

jeanetteclark opened this issue Apr 26, 2022 · 2 comments

Comments

@jeanetteclark
Copy link
Contributor

Loving the package, thank you for your hard work!

Based on my own experience setting up my credentials, and a flurry of related issues (#173, #179, #177, #184, #193), I think that it might be a nice improvement if assert_base_url does a little more checking to help guide users to the correct URL structure.

an assert_that the URL does not start with https:// statement would be the most helpful, and perhaps mention of no trailing slash in the existing statement for endsWith may also be useful.

I can make a quick PR if this is of interest

@juliasilge
Copy link
Collaborator

That would be super @jeanetteclark! 🙌 A PR to improve assert_base_url() would be most welcome.

@juliasilge
Copy link
Collaborator

Closed in #258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants