Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add assertion to check that URL does not start with the protocol #258

Merged
merged 4 commits into from
Apr 27, 2022

Conversation

jeanetteclark
Copy link
Contributor

addresses #257

I also added a little info about not including the protocol to the documentation of qualtrics_api_credentials

jeanetteclark and others added 4 commits April 26, 2022 15:12
also add a corresponding test for this assertion
…ltrics_api_credentials

an attempt to help users get to the correct format faster, since they won't see an issue until they make a call to the API
Copy link
Collaborator

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @jeanetteclark! 🙌

@juliasilge juliasilge merged commit e350dd3 into ropensci:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants