Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache NULL data read_marketdata returns #52

Closed
wilsonfreitas opened this issue Aug 13, 2022 · 1 comment
Closed

Don't cache NULL data read_marketdata returns #52

wilsonfreitas opened this issue Aug 13, 2022 · 1 comment

Comments

@wilsonfreitas
Copy link
Collaborator

read_marketdata returns NULL when downloaded data is invalid.
In this situation the download data is cached and the parsed data, in this case NULL, is also cached.
Actually NULL is being cached in a rds file and the invalid downloaded file is also cached.

If read_marketdata returns NULL, the rds file can't be created and the given file, input file, should be removed either.

Simply, don't cache invalid or incorrect data.

wilsonfreitas added a commit that referenced this issue Aug 13, 2022
@wilsonfreitas
Copy link
Collaborator Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant