Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using page[size] rather than rows for api call #18

Merged
merged 2 commits into from
Mar 21, 2018
Merged

using page[size] rather than rows for api call #18

merged 2 commits into from
Mar 21, 2018

Conversation

kjgarza
Copy link
Contributor

@kjgarza kjgarza commented Mar 19, 2018

the DataCite REST api follows the jsonapi spec for pagination http://jsonapi.org/format/#fetching-pagination

the DataCite REST api follows the  jsonapi spec for pagination http://jsonapi.org/format/#fetching-pagination
@sckott
Copy link
Contributor

sckott commented Mar 19, 2018

thanks @kjgarza !

can you also change offset to page[offset] ?

@sckott
Copy link
Contributor

sckott commented Mar 21, 2018

thanks very much @kjgarza !

@sckott sckott added this to the v0.4 milestone Mar 21, 2018
@sckott sckott merged commit db75c5b into ropensci:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants