Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress readr/vroom warnings #45

Merged
merged 1 commit into from
May 27, 2022
Merged

suppress readr/vroom warnings #45

merged 1 commit into from
May 27, 2022

Conversation

mpadge
Copy link
Member

@mpadge mpadge commented May 25, 2022

@cboettig Another dependency update that requires changes here. readr::read_csv now passes directly to vroom which does this:
https://github.com/tidyverse/vroom/blob/2218ba0e311e200e359469542e049ab6f34a5683/R/path.R#L49

That soft_deprecate is issued as a warning, and thus packages depending on rdflib fail R CMD checks. Here's an equivalent fix from rOpenSci's {nasapower} pkg courtesy of @palderman. I haven't thought about the consequences of this change, or whether there might be edge cases not compatible with passing literal args via I(), so maybe think about that at least briefly before merging this? Thanks!

@cboettig cboettig merged commit 649cb31 into ropensci:master May 27, 2022
@cboettig
Copy link
Member

Wow, interesting. Thanks.

@eblondel
Copy link

eblondel commented Mar 9, 2023

Dear @cboettig I received some CRAN notification for atom4R, that makes use of rdflib package, and relates to this change. I've reported it at eblondel/atom4R#26

Although the fix is already there (thanks @mpadge for this), CRAN reports the issue because rdflib has not yet been updated in CRAN. Do you plan to submit the pending package revision to CRAN soon?

@cboettig
Copy link
Member

cboettig commented Mar 9, 2023

thanks for the ping. yup, can do. iiuc, we just need to release the current github version of rdflib to CRAN to resolve this, yes?

@eblondel
Copy link

eblondel commented Mar 9, 2023

Thanks @cboettig for your swift reply. Yes I think so, @mpadge 's PR fixed the issue.

@cboettig
Copy link
Member

cboettig commented Mar 9, 2023

patch on it's way to CRAN now 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants