Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference rdhs::model_datasets internally #118

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Conversation

jeffeaton
Copy link
Collaborator

Description

If rdhs is not loaded in the global namespace, then create_new_filenames() throws an error:

Error in strsplit(data$FileName, ".", fixed = TRUE) : 
  object 'model_datasets' not found
> traceback()
10: strsplit(data$FileName, ".", fixed = TRUE)
9: lapply(., function(x) x[1])
8: unlist(.)
7: strsplit(data$FileName, ".", fixed = TRUE) %>% lapply(function(x) x[1]) %>% 
       unlist()
6: create_new_filenames(model_datasets)
5: private$check_available_datasets(dataset_filenames, download_option, 
       reformat)
4: client$get_datasets(dataset_filenames, download_option = download_option, 
       reformat = reformat, all_lower = all_lower, output_dir_root = output_dir_root, 
       clear_cache = clear_cache, ...)
3: rdhs::get_datasets(hrd)

This patch references model_datasets with rdhs::model_datasets to fix this.

@jeffeaton jeffeaton requested a review from OJWatson May 28, 2021 07:30
@OJWatson OJWatson merged commit 39d0961 into master Jun 1, 2021
@OJWatson
Copy link
Collaborator

OJWatson commented Jun 1, 2021

LGTM @jeffeaton - Sorry for delay in picking this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants