Fix #124 #125
Merged
Fix #124 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clarify .gen_sheet_tag; because the second parameter is not always `cmax`
|
@pbrohan I can't assign you to be the reviewer of this PR, as only ropensci core members can be a reviewer. But I wanted to make sure you agree with this. Thank you very much! |
|
Sadly I’m away from my PC until Sunday evening, but I’ll look at it when I
get in!
Sorry, and thanks!
…On Sat, 5 Aug 2023 at 14:36, chainsawriot ***@***.***> wrote:
@pbrohan <https://github.com/pbrohan> I can't assign you to be the
reviewer of this PR, as only ropensci core members can be a reviewer. But I
wanted to make sure you agree with this. Thank you very much!
—
Reply to this email directly, view it on GitHub
<#125 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKP7BMWS2VDQ2KI6XEUSDUTXTZD6FANCNFSM6AAAAAA3FHDTFQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@chainsawriot All looks good to me. Sorry for the error in the first place, thanks so much for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.