Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to tidync from ncdf4? #95

Closed
sckott opened this issue Nov 5, 2020 · 5 comments
Closed

switch to tidync from ncdf4? #95

sckott opened this issue Nov 5, 2020 · 5 comments
Milestone

Comments

@sckott
Copy link
Contributor

sckott commented Nov 5, 2020

No description provided.

@sckott sckott added this to the v0.8 milestone Nov 5, 2020
sckott added a commit that referenced this issue Nov 5, 2020
…ting tidync now

still need to adjust tests, pull out ncdf4, adjust ncdf_summary fxn to use tidync instead
@sckott
Copy link
Contributor Author

sckott commented Nov 10, 2020

@rmendels pinging you here to make sure you're aware of the tidync details.

@mdsumner sorry to maybe re-hash the conversation we had in slack ... I want to check what you think about the approach I've taken. Here's the code that uses tidync https://github.com/ropensci/rerddap/blob/tidync/R/zzz.r#L67-L74 - where the input var x is a path to the netcdf file. I know in slack you mentioned maybe doing something like purrr::map(tn$grid$grid, ~activate(tn, .x) %>% hyper_tibble()) where tn is the output of tidync(x). I don't understand enough what the right thing to do here is, but between you two i'm hoping we can pick the best approach here for the most people

@rmendels
Copy link
Collaborator

@sckott @mdsumner - For my packages what I need is where the downloaded netcdf file is stored (and that is still there), the packages are indifferent to how rerddap then reads in and melts the data. For users of the rerddap package, if the end result is different in significant ways than in the present version, that could break scripts. I know next to nothing about the internals of tidync, and the real question is using tidync to ingest and 'melt' the netcdf file, rather than using the code you have in the present version of rerddap to do the same, and the best way to use tidync to do so. For the latter question I have no idea, for the former as I said, as long as the end result is basically the same, it doesn't affect anything, sort of one of those internal black-box details that the user doesn't know about.

@sckott
Copy link
Contributor Author

sckott commented Nov 11, 2020

thanks @rmendels

@mdsumner
Copy link

I'm similar, didn't know the context when answering "how to suck out every grid as a dataframe?".

tidync just lets you choose, array output, df output, or just updated meta-print (what slices would be made if read triggered .. )

@sckott
Copy link
Contributor Author

sckott commented Dec 3, 2020

Thanks both for the input.

@sckott sckott modified the milestones: v0.8, v1.0 Mar 5, 2021
@rmendels rmendels closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants