Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restez and duckdb 0.9.0 #55

Closed
krlmlr opened this issue Sep 27, 2023 · 2 comments · Fixed by #56
Closed

restez and duckdb 0.9.0 #55

krlmlr opened this issue Sep 27, 2023 · 2 comments · Fixed by #56
Assignees

Comments

@krlmlr
Copy link

krlmlr commented Sep 27, 2023

We're in the process of releasing duckdb 0.9.0. Running your checks with the updated duckdb version revealed problems: https://github.com/duckdb/duckdb-r/blob/main/revdep/problems.md#restez . We would like to send the update to CRAN as soon as possible.

duckdb 0.9.0 might reorder rows more aggressively than previous versions did. If your queries rely on a particular row output order, please make sure that you specify it.

Can you please confirm? Installation instructions on https://github.com/duckdb/duckdb-r/tree/main#installation-from-r-universe are up to date. Thanks!

CC @hannes.

@krlmlr
Copy link
Author

krlmlr commented Oct 11, 2023

Just a heads-up, we're releasing duckdb to CRAN today.

@joelnitta joelnitta self-assigned this Oct 16, 2023
joelnitta added a commit that referenced this issue Oct 16, 2023
changed by new duckdb version 0.9.0
#55
joelnitta added a commit that referenced this issue Oct 16, 2023
changed by new duckdb version 0.9.0
#55
@joelnitta
Copy link
Contributor

@krlmlr Thanks for the heads-up, and sorry for my late reply.

There was one bug that I had to fix -- the database size in memory got smaller as a result of the update, which broke a test. All other tests pass.

The only querying of the database looks like this:

  qry <- paste0("SELECT accession,", nm,
                " FROM nucleotide WHERE accession IN ", qry_id)

where nm includes one or more column names, and qry_id includes ID numbers.

I don't think row order should matter for any of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants