Reviews - to do

[sckott]

reviews requested:

• @noamross
• @layamane

[sckott]

see #46

[noamross]

Is it in-scope to review the API itself here? I don't know the whole story but it seems that the API itself is being developed by ROpenSci to be hosted by rfishbase itself at some point, is that correct? And that the API is primarily an interface to the FishBase SQL database?
@cboettig

[cboettig]

We'd certainly appreciate that if you did -- the API is primarily in Ruby;
code at https://github.com/ropensci/fishbaseapi, but up to you I think.
@sckott thoughts?

On Wed, May 20, 2015 at 8:05 AM Noam Ross notifications@github.com wrote:

Is it in-scope to review the API itself here? I don't know the whole story
but it seems that the API itself is being developed by ROpenSci to be
hosted by rfishbase itself at some point, is that correct? And that the API
is primarily an interface to the FishBase SQL database?

—
Reply to this email directly or view it on GitHub
#45 (comment).

[noamross]

I won't be able to review the API's code, but I'll give some feedback on
endpoints, etc.

On Wed, May 20, 2015 at 8:39 AM Carl Boettiger notifications@github.com
wrote:

We'd certainly appreciate that if you did -- the API is primarily in Ruby;
code at https://github.com/ropensci/fishbaseapi, but up to you I think.
@sckott thoughts?

On Wed, May 20, 2015 at 8:05 AM Noam Ross notifications@github.com
wrote:

Is it in-scope to review the API itself here? I don't know the whole
story
but it seems that the API itself is being developed by ROpenSci to be
hosted by rfishbase itself at some point, is that correct? And that the
API
is primarily an interface to the FishBase SQL database?

—
Reply to this email directly or view it on GitHub
<#45 (comment)
.

—
Reply to this email directly or view it on GitHub
#45 (comment).

[sckott]

@noamross yes, we built the API, but of course any data problems we can't directly fix - we just get the dump from fishbase. If there's anything in the API itself (the endpoints we chose to provide, API behavior, etc.) we can address them

[sckott]

@noamross okay, sounds good

[cboettig]

Reviews are in (#46 and #49), so we can close this.