Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict arg to name_backbone_checklist #565

Closed
jhnwllr opened this issue Dec 1, 2022 · 1 comment
Closed

Add strict arg to name_backbone_checklist #565

jhnwllr opened this issue Dec 1, 2022 · 1 comment
Labels
Milestone

Comments

@jhnwllr
Copy link
Collaborator

jhnwllr commented Dec 1, 2022

#564

@jhnwllr jhnwllr added the feature label Dec 1, 2022
@damianooldoni
Copy link
Collaborator

Thanks @jhnwllr to take into account this improvement. Indeed, we use strict=TRUE quite a lot as it is important to have only exact mathes in many situations.

Maybe you can consider the option to not only expose the strict arg but any other argument of name_backbone via ellipsis (...)? We did it in our wrapper function inborutils::gbif_species_name_match as it provides the user the maximum flexibility possible and makes what a wrapper function should do: exposing the very same set of functionalities as the central function, name_backbone in this case.

Notice that we are going to supersede our function and promoting the use of yours in the documentation: see PR inbo/inborutils#121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants