Guess domain name with hyphen(s) correctly #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! In v0.7.7,
robotstxt:::guess_domain("www.some-domain.com")
returnswww.some
, also when prefixinghttp(s)://
or suffixing/some/path/index.html
.I suggest to rely on a more common parse_url.R variant. Maybe from httr?
This is a quick attempt to integrate the bug fix. Please feel free to take it where you feel it's best.