New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree data( #47) #62
Tree data( #47) #62
Conversation
Study external fxn handles missing data gracefully Added function to retrieve taxonomic IDs
That looks @dwinter. Thanks for doing that! Were you thinking that all of this should go into a vignette or just the summary functions? |
Hi @fmichonneau, So, I was really questioning wether the summarize* functions. were going to be very useful. It's hard to predict what users will want to do with the IDs, and we can't really write wrappers for every package the might use them?So, it might make more sense to have If you and @josephwb agree. Maybe I'll modify this PR to remove the summarize* functions, but include a similar example in the vignette (maybe finding sequences for a given taxon). We can use that to talk about packages that can make use of the other IDs.? |
*SQUASH* rewrite tree_data docs Explicitly print for tests of printed output (new for testthat 1.0) taxonomy_taxon -> taxonomy_taxon_info for v3 Pick study_external test case that doesn't throw warning Comment out not-very-helpful summary functions Add sequencing fetching e.g. to data mashup vignette Use new strip_ott_id fxn in metaanalysis vignette
Hey @josephwb and @fmichonneau I think this should now pass all tests. Just to remind you, it adds two functions, I decided to remove the Oh, and a new version of Tell me what you think |
Thanks for this! I think it's going to be really useful. |
@fmichonneau and @josephwb
What do you think about this as a solution to #47? Here's how it works at the moment.
Demonstration
There are two functions for getting external IDs, one for studies...
study_external_IDs("pg_1940")
... and another for taxa
taxon_external_IDs(712902)
Those two only get you as far as finding IDs, rather than importing data into an R session. I did write some (currently un-exported) functions to summarise a set of nucleotide or popset IDs. Here's one example
I'm not sure how useful this really is, and think it might just be better to document this sort of workflow including packages for ncbi/gbif/whatever?
What's in the PR
In addition to the functions there is
strip_ott_ids
that's let's users optionally replace underscores with spacesrentrez
to get the NCBI data