Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start work on /help-wanted/ page #212

Merged
merged 13 commits into from
Nov 18, 2021
Merged

start work on /help-wanted/ page #212

merged 13 commits into from
Nov 18, 2021

Conversation

maelle
Copy link
Member

@maelle maelle commented May 28, 2021

Fix #192

TODOS

  • Fetch JSON from URL.
  • Add docs of this in the README.
  • Link the page from the navbar under packages.
  • Link from other places in particular community page.

Some notes

  • The JSON I am using is a fake one. I assume we'd have a script to run to update it. I wonder whether it should be automatic (I am now thinking it'd be fine to not clean the data if the page included some disclaimer). In all cases, we should probably create renv files for the different R tasks in roweb3 (the use cases, the help wanted issues, the newsletter). Ideally the script and renv file would live in roweb3?
  • At the top of the page, the cards are three random issues.
  • I don't use the updated field at the moment.
  • Should there also be a RSS and JSON feeds one could actually subscribe to?

Next steps:

@steffilazerte I'll take any comment on the page display / where it's linked from + on the workflow for updating the JSON. We also need to replace "BLABLABLA".

README.md Show resolved Hide resolved
data/help/issues.json Outdated Show resolved Hide resolved
@maelle maelle changed the title start work on help wanted page start work on /help-wanted/ page May 28, 2021
@maelle
Copy link
Member Author

maelle commented May 28, 2021

@maelle maelle requested a review from steffilazerte May 31, 2021 08:17
Copy link
Member

@steffilazerte steffilazerte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great! I've added some comments, and made a suggestion for filling in the blahblahblah 😁

For the JSON, you can either adapt my comms/content-n-programs/twitter-promo/issues/issues.R script, or perhaps I should create a mini package for grabbing use cases and help-wanted issues that could be used here, and then in in my twitter-promo section. You did suggest making a small package for my utils scripts, so perhaps this would be the way to go?

content/help-wanted/_index.md Outdated Show resolved Hide resolved
themes/ropensci/layouts/help-wanted/list.html Outdated Show resolved Hide resolved
Co-authored-by: Steffi LaZerte <steffi@steffi.ca>
@maelle
Copy link
Member Author

maelle commented Oct 18, 2021

@steffilazerte what's your take on

Should there also be a RSS and JSON feeds one could actually subscribe to?

@steffilazerte
Copy link
Member

@steffilazerte what's your take on

Should there also be a RSS and JSON feeds one could actually subscribe to?

I think it's overkill, especially as we'll be tweeting as well.

@maelle
Copy link
Member Author

maelle commented Nov 4, 2021

Ok, thanks @steffilazerte!

I'll wait for the Netlify URL before working on this again.

@maelle maelle marked this pull request as ready for review November 16, 2021 10:47
Copy link
Member

@steffilazerte steffilazerte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So exciting! I'm still at a loss how the Netlify all worked out but at least it did, thanks!

I have a couple of suggestions, but only if you agree, I definitely don't feel that strongly about them 😁 Can't wait to see this go live!

themes/ropensci/layouts/help-wanted/list.html Outdated Show resolved Hide resolved
themes/ropensci/layouts/help-wanted/list.html Outdated Show resolved Hide resolved
</p>
</div>
</div>
<div class="row case-cards mt-5">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the preview, these look a little funny being just blue. Perhaps they could be the blue with the rOpenSci logo? Or similar to the blog featured cards, where the text is on the blue background?

maelle and others added 5 commits November 18, 2021 16:12
Co-authored-by: Steffi LaZerte <steffi@steffi.ca>
Co-authored-by: Steffi LaZerte <steffi@steffi.ca>
@maelle maelle merged commit 82a0741 into master Nov 18, 2021
@maelle maelle deleted the issues-help branch November 18, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feed of "help wanted" issues
2 participants