-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make website partly multilingual #506
Conversation
Looks really nice Maëlle !! Addin one TODO:
|
which post? btw I think we should remove the "Spanish" tags since they will be listed in a different way, and I think we should translate all tags. let's discuss! |
Agree about the translation of the tag! This blog post: https://ropensci.org/blog/2021/09/21/creando-tu-r-universe/ |
oh thanks, that's a post present in Spanish only, let's see whether that breaks anything! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revisiones menores
content/blog/2022-04-19-software-review-editorial-challenges/index.es.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
…ndex.es.md Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
@yabellini ¡muchas gracias! |
I'd take out "Other Languages" and write the language names in the respective language. |
Not in the sidebar, but in the feature card. |
I really like this. Perhaps one idea to make the translation links more intuitive, if you add the current language to the list, and make that bold. So maybe something like this: Or indeed perhaps even better would be a dropdown element (if we can style it nicely) so it is intuitive what is the current value, and that it can be changed. |
using that for now, excellent idea |
Merge branch 'main' into blog-babel # Conflicts: # content/blog/2023-02-27-runiverse-discovering/index.es.md # content/blog/2023-02-28-r-universe-stars-2-en/index.fr.md # content/blog/2023-02-28-r-universe-stars-2-en/index.md
🎉 |
Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
* May event * Add authors to coworking * Tweak footnote * Adding package and mentors training (#528) * feat: make website partly multilingual (#506) Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com> * add slug * debug (#530) * fix prod deploy cc @yabellini * actually fix deploy * add explicit config (#533) * Mo interview - R-Universe (#517) Co-authored-by: Steffi LaZerte <steffi@steffi.ca> Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se> * add redirect thx @drmowinckels cc @yabellini * rm now useless preface * rm now useless preface * link to multilingualism milestone * small alterations to clarify text (#535) * remove duplicate banner * Technote about cranscraper (#536) * declutter a little bit * add waywiser tech note (#529) * add waywiser tech note * add Mastodon * community * pkg version * Add slug and tweak representation of date --------- Co-authored-by: Steffi LaZerte <steffi@steffi.ca> * fix config order * First draf of introducing champions-mentors teams (#532) Co-authored-by: Steffi LaZerte <steffi@steffi.ca> Co-authored-by: Adam H. Sparks <adamhsparks@icloud.com> * Reproduce changes by @steffilazerte for the newsletter * Draft June coworking event (#541) * Draft June * Fix link * Fix twitter * Add orcid * Starting the blog post introducing Marcos and Lukas (#539) * Starting the blog post * Apply suggestions from code review * Update content/blog/2023-04-18-champions-program-teams/index.md * Apply suggestions from code review Co-authored-by: Steffi LaZerte <steffi@steffi.ca> * Marcos author profile * Lukas author profile * Fix Marcos bio * Update content/author/lukas-wallrich/_index.es.md Co-authored-by: Steffi LaZerte <steffi@steffi.ca> --------- Co-authored-by: Steffi LaZerte <steffi@steffi.ca> * April news (#537) Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com> Co-authored-by: Steffi LaZerte <steffi@steffi.ca> * bilikisu-christina blog post intro (#542) * bilikisu-christina blog post intro * Update content/blog/2023-04-25-champions-program-teams/index.md * Update content/blog/2023-04-25-champions-program-teams/index.md * Update content/blog/2023-04-25-champions-program-teams/index.md * Update content/blog/2023-04-25-champions-program-teams/index.md * Update content/blog/2023-04-25-champions-program-teams/index.md * Update content/blog/2023-04-25-champions-program-teams/index.md * Update content/blog/2023-04-25-champions-program-teams/index.md * Adding bilikisu author profile * Adding Christina profile author * Update content/blog/2023-04-25-champions-program-teams/index.md Co-authored-by: Steffi LaZerte <steffi@steffi.ca> * Apply suggestions from code review Co-authored-by: Steffi LaZerte <steffi@steffi.ca> * Update content/blog/2023-04-25-champions-program-teams/index.md * Adding link and a break * Apply suggestions from code review --------- Co-authored-by: Steffi LaZerte <steffi@steffi.ca> * Karthik Keynote and Yani talk at CSV,Conf (#550) * tweaks R-universe posts (#555) * fix: make r-universe link conditional (#546) * Caro-Mo-Intro - blog post skeleton (#551) Co-authored-by: Athanasia Monika Mowinckel <14014329+drmowinckels@users.noreply.github.com> Co-authored-by: Steffi LaZerte <steffi@steffi.ca> Co-authored-by: Carolina Pradier <carolinapradier@gmail.com> * Fixing authors folder names (#559) Co-authored-by: Athanasia Monika Mowinckel <14014329+drmowinckels@users.noreply.github.com> Co-authored-by: Steffi LaZerte <steffi@steffi.ca> Co-authored-by: Carolina Pradier <carolinapradier@gmail.com> * May event * Tweak footnote * Fix yaml * Add author files - Alex Koiter - Hannah Owens * Correct/combine François authorship --------- Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com> Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se> Co-authored-by: Athanasia Monika Mowinckel <14014329+drmowinckels@users.noreply.github.com> Co-authored-by: Jeroen Ooms <jeroenooms@gmail.com> Co-authored-by: Adam H. Sparks <adamhsparks@icloud.com> Co-authored-by: Carolina Pradier <carolinapradier@gmail.com>
Summary of the changes
With this PR the English pages are "clean": the links to non English content have a "lang='es'" tag for instance. There's very little text in Spanish (only the highlight on https://deploy-preview-506--ropensci.netlify.app/blog/ that says "some posts are also available in Spanish". On the contrary, the Spanish pages are full of English pieces: the footer and navbar in particular.
However this is an improvement over the current situation.
Feedback needed on
Feedback not needed on