Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make website partly multilingual #506

Merged
merged 49 commits into from
Mar 28, 2023
Merged

feat: make website partly multilingual #506

merged 49 commits into from
Mar 28, 2023

Conversation

maelle
Copy link
Member

@maelle maelle commented Mar 3, 2023

Summary of the changes

With this PR the English pages are "clean": the links to non English content have a "lang='es'" tag for instance. There's very little text in Spanish (only the highlight on https://deploy-preview-506--ropensci.netlify.app/blog/ that says "some posts are also available in Spanish". On the contrary, the Spanish pages are full of English pieces: the footer and navbar in particular.

However this is an improvement over the current situation.

Feedback needed on

  • anything you find amiss, ugly. Suggestions welcome!
  • ⚠️ would you find it clearer/better to have a subdomain per language (esp.ropensci.org) as opposed to a folder per language?
  • how to make the warning in the navbar nicer.
  • the blog featured cards in particular: do the language links look ok? See below

image

Feedback not needed on

  • the navbar and the footer being in English... we'd translate them in another PR later when we translate more static files.

@yabellini
Copy link
Member

yabellini commented Mar 3, 2023

Looks really nice Maëlle !!

Addin one TODO:

  • Add the language tag to all the pots (the list is missing the one I contributed about r-universe some time ago, for example)

@maelle
Copy link
Member Author

maelle commented Mar 3, 2023

Add the language tag to all the pots (the list is missing the one I contributed about r-universe some time ago, for example)

which post? btw I think we should remove the "Spanish" tags since they will be listed in a different way, and I think we should translate all tags. let's discuss!

@yabellini
Copy link
Member

Agree about the translation of the tag! This blog post: https://ropensci.org/blog/2021/09/21/creando-tu-r-universe/

@maelle
Copy link
Member Author

maelle commented Mar 3, 2023

oh thanks, that's a post present in Spanish only, let's see whether that breaks anything!

config.toml Outdated Show resolved Hide resolved
Copy link
Member

@yabellini yabellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisiones menores

config.toml Outdated Show resolved Hide resolved
content/archive/_index.es.md Outdated Show resolved Hide resolved
content/author/_index.es.md Outdated Show resolved Hide resolved
content/author/_index.es.md Outdated Show resolved Hide resolved
content/author/alejandra-bellini/_index.es.md Outdated Show resolved Hide resolved
content/blog/2021-07-27-censo2017/index.es.md Outdated Show resolved Hide resolved
maelle and others added 4 commits March 7, 2023 17:11
Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
…ndex.es.md

Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
@maelle
Copy link
Member Author

maelle commented Mar 7, 2023

@yabellini ¡muchas gracias!

@karthik
Copy link
Member

karthik commented Mar 7, 2023

I'd take out "Other Languages" and write the language names in the respective language.

@karthik
Copy link
Member

karthik commented Mar 7, 2023

Not in the sidebar, but in the feature card.

@maelle
Copy link
Member Author

maelle commented Mar 7, 2023

The feature card does not have the text Other languages in the most recent version:

image

@jeroen
Copy link
Member

jeroen commented Mar 23, 2023

I really like this.

Perhaps one idea to make the translation links more intuitive, if you add the current language to the list, and make that bold. So maybe something like this:

Screenshot 2023-03-23 at 5 12 00 PM

Or indeed perhaps even better would be a dropdown element (if we can style it nicely) so it is intuitive what is the current value, and that it can be changed.

@maelle
Copy link
Member Author

maelle commented Mar 24, 2023

Perhaps one idea to make the translation links more intuitive, if you add the current language to the list, and make that bold.

using that for now, excellent idea

Merge branch 'main' into blog-babel

# Conflicts:
#	content/blog/2023-02-27-runiverse-discovering/index.es.md
#	content/blog/2023-02-28-r-universe-stars-2-en/index.fr.md
#	content/blog/2023-02-28-r-universe-stars-2-en/index.md
@maelle maelle marked this pull request as ready for review March 28, 2023 08:50
@maelle maelle changed the title start work on multilingual blog, youpi feat: make website partly multilingual Mar 28, 2023
@maelle maelle merged commit df916fe into main Mar 28, 2023
@jeroen
Copy link
Member

jeroen commented Mar 28, 2023

🎉

steffilazerte pushed a commit that referenced this pull request May 5, 2023
Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
steffilazerte added a commit that referenced this pull request May 24, 2023
* May event

* Add authors to coworking

* Tweak footnote

* Adding package and mentors training (#528)

* feat: make website partly multilingual (#506)

Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>

* add slug

* debug (#530)

* fix prod deploy cc @yabellini

* actually fix deploy

* add explicit config (#533)

* Mo interview - R-Universe (#517)

Co-authored-by: Steffi LaZerte <steffi@steffi.ca>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>

* add redirect thx @drmowinckels cc @yabellini

* rm now useless preface

* rm now useless preface

* link to multilingualism milestone

* small alterations to clarify text (#535)

* remove duplicate banner

* Technote about cranscraper (#536)

* declutter a little bit

* add waywiser tech note (#529)

* add waywiser tech note

* add Mastodon

* community

* pkg version

* Add slug and tweak representation of date

---------

Co-authored-by: Steffi LaZerte <steffi@steffi.ca>

* fix config order

* First draf of introducing champions-mentors teams (#532)

Co-authored-by: Steffi LaZerte <steffi@steffi.ca>
Co-authored-by: Adam H. Sparks <adamhsparks@icloud.com>

* Reproduce changes by @steffilazerte for the newsletter

* Draft June coworking event (#541)

* Draft June

* Fix link

* Fix twitter

* Add orcid

* Starting the blog post introducing Marcos and Lukas (#539)

* Starting the blog post

* Apply suggestions from code review

* Update content/blog/2023-04-18-champions-program-teams/index.md

* Apply suggestions from code review

Co-authored-by: Steffi LaZerte <steffi@steffi.ca>

* Marcos author profile

* Lukas author profile

* Fix Marcos bio

* Update content/author/lukas-wallrich/_index.es.md

Co-authored-by: Steffi LaZerte <steffi@steffi.ca>

---------

Co-authored-by: Steffi LaZerte <steffi@steffi.ca>

* April news (#537)

Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
Co-authored-by: Steffi LaZerte <steffi@steffi.ca>

* bilikisu-christina blog post intro (#542)

* bilikisu-christina blog post intro

* Update content/blog/2023-04-25-champions-program-teams/index.md

* Update content/blog/2023-04-25-champions-program-teams/index.md

* Update content/blog/2023-04-25-champions-program-teams/index.md

* Update content/blog/2023-04-25-champions-program-teams/index.md

* Update content/blog/2023-04-25-champions-program-teams/index.md

* Update content/blog/2023-04-25-champions-program-teams/index.md

* Update content/blog/2023-04-25-champions-program-teams/index.md

* Adding bilikisu author profile

* Adding Christina profile author

* Update content/blog/2023-04-25-champions-program-teams/index.md

Co-authored-by: Steffi LaZerte <steffi@steffi.ca>

* Apply suggestions from code review

Co-authored-by: Steffi LaZerte <steffi@steffi.ca>

* Update content/blog/2023-04-25-champions-program-teams/index.md

* Adding link and a break

* Apply suggestions from code review

---------

Co-authored-by: Steffi LaZerte <steffi@steffi.ca>

* Karthik Keynote and Yani talk at CSV,Conf (#550)

* tweaks R-universe posts (#555)

* fix: make r-universe link conditional (#546)

* Caro-Mo-Intro - blog post skeleton (#551)

Co-authored-by: Athanasia Monika Mowinckel <14014329+drmowinckels@users.noreply.github.com>
Co-authored-by: Steffi LaZerte <steffi@steffi.ca>
Co-authored-by: Carolina Pradier <carolinapradier@gmail.com>

* Fixing authors folder names (#559)

Co-authored-by: Athanasia Monika Mowinckel <14014329+drmowinckels@users.noreply.github.com>
Co-authored-by: Steffi LaZerte <steffi@steffi.ca>
Co-authored-by: Carolina Pradier <carolinapradier@gmail.com>

* May event

* Tweak footnote

* Fix yaml

* Add author files
- Alex Koiter
- Hannah Owens

* Correct/combine François authorship

---------

Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Athanasia Monika Mowinckel <14014329+drmowinckels@users.noreply.github.com>
Co-authored-by: Jeroen Ooms <jeroenooms@gmail.com>
Co-authored-by: Adam H. Sparks <adamhsparks@icloud.com>
Co-authored-by: Carolina Pradier <carolinapradier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants