Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all vignettes #154

Open
elinw opened this issue Apr 4, 2022 · 3 comments
Open

Review all vignettes #154

elinw opened this issue Apr 4, 2022 · 3 comments

Comments

@elinw
Copy link
Contributor

elinw commented Apr 4, 2022

To get things to build we had to change a lot of the vignette chunks to eval=FALSE.We need to work through each one to get them all running.
Also let's add chunk names as much as possible and silence the messages that come with loading dplyr etc.

@maelle
Copy link
Member

maelle commented May 26, 2022

forecast_advisory.Rmd is failing.

One of the first chunks need to be changed to

fstadv <- rrricanesdata::fstadv |> filter(Key == key, Adv <= adv)

but then I get

Quitting from lines 38-40 (forecast_advisory.Rmd) 
Erreur dans st_sf(x, ..., agr = agr, sf_column_name = sf_column_name) : 
  no simple features geometry column present
Appels : <Anonymous> ... process_cpl_read_ogr -> st_as_sf -> st_as_sf.data.frame -> st_sf

@maelle
Copy link
Member

maelle commented Oct 3, 2022

Were the vignettes fixed? Any help needed?

@maelle
Copy link
Member

maelle commented Apr 7, 2023

@elinw 👋! Is any help needed? Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants