Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue which causes variables with multiple unknown classes and… #75

Merged
merged 2 commits into from
Jun 8, 2017

Conversation

elinw
Copy link
Collaborator

@elinw elinw commented Jun 3, 2017

… no known classes to throw an error.

@elinw elinw requested a review from michaelquinn32 June 3, 2017 17:01
…ouble_strange_class

Conflicts:
	tests/testthat/test-skim_v.R
@elinw elinw mentioned this pull request Jun 7, 2017
@elinw elinw requested review from earino and haozhu233 June 8, 2017 13:24
@elinw
Copy link
Collaborator Author

elinw commented Jun 8, 2017

This issue has also come up with handling the sf data.
#88

@earino
Copy link
Contributor

earino commented Jun 8, 2017

Did some tests, it prints out nice warnings now instead of just going kaboom! Good work @elinw :-)

@earino earino merged commit e472630 into master Jun 8, 2017
@elinw elinw deleted the double_strange_class branch June 19, 2017 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants