Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Maybe move to R6 setup #100

Closed
sckott opened this issue Jun 30, 2017 · 1 comment · Fixed by #108
Closed

Maybe move to R6 setup #100

sckott opened this issue Jun 30, 2017 · 1 comment · Fixed by #108
Milestone

Comments

@sckott
Copy link
Contributor

sckott commented Jun 30, 2017

if staring using R6 package, could then have separate objects for different connections, so easier to do > 1 connections per R session - not sure of best way to use these connections though - either pass in as a parameter to methods like

con <- solr_connect()
solr_search(con, q = "*:*")

or if we modify include methods in the connection object, then e.g,

con <- solr_connect()
con$solr_search(q = "*:*")

no longer need to pass in connection object as a parameter, but breaks code in diff. way in that you have to call methods on a R6 class

would help #99 by we could make explicit methods for params vs. data, which then go into query params and body, respectively

@sckott
Copy link
Contributor Author

sckott commented Jun 30, 2017

if this is done, may need to roll a diff. pkg as solrium2

sckott added a commit that referenced this issue Jul 12, 2017
update all man files for new roxygn2 version
@sckott sckott added this to the v0.5 milestone Sep 28, 2017
sckott added a commit that referenced this issue Oct 7, 2017
fix #100 changed to using r6 setup for solrclient - allowing users to go object route or functional route
update readme
update tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant