-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off regionalisation in overline()
#510
Comments
Agreed. I think we should set the threshold to a high number as you suggest. Are you happy to give this a go Joey? Thanks for reporting, will save lots of people lots of time I think. |
Yes, I'll have a go! |
Ok, this issue already seems to be fixed! I was using v1.0.1 of stplanr. In v1.0.2, the latest version, regionalise is set to 1e+09 by default. I should have updated the package :) |
Aha, well spotted. Always worth checking package versions. I think this may be a duplicate of a previous issue. Will close for now and search for the issue. |
The issue was diagnosed and fixed here: #466 Here's how I found it (not easy to find as no mention of regionalisation in the issue): https://github.com/ropensci/stplanr/issues?q=regionalisation |
Using
overline()
on a large dataset, the function failed with the default method. But it worked for the same dataset when I turned off regionalisation:It appears to make sense to have regionalisation turned off by default in
overline()
. Currently the only way to turn it off seems to be to provide a very high number, e.g.regionalise = 1e+07
. There is noregionalise = FALSE
option.The text was updated successfully, but these errors were encountered: