Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance of tar_delete(), tar_destroy(), and tar_prune() on the cloud #1171

Closed
3 tasks done
wlandau opened this issue Oct 18, 2023 · 2 comments
Closed
3 tasks done

Comments

@wlandau
Copy link
Collaborator

wlandau commented Oct 18, 2023

Prework

  • I understand and agree to help guide.
  • I understand and agree to contributing guide.
  • New features take time and effort to create, and they take even more effort to maintain. So if the purpose of the feature is to resolve a struggle you are encountering personally, please consider first posting a "trouble" or "other" issue so we can discuss your use case and search for existing solutions first.

Proposal

For pipelines with thousands of targets, tar_delete() and tar_destroy() are slow because they delete each object one-by-one with a call to paws.storage::s3()$delete_object(). It would be faster to delete entire groups of objects with paws.storage::s3()$delete_objects(), plural. targets would probably need another utility in R/utils_aws.R for this, as well as similar functionality for Google Cloud.

@wlandau wlandau self-assigned this Oct 18, 2023
wlandau pushed a commit that referenced this issue Nov 7, 2023
@wlandau wlandau changed the title Performance of tar_delete() and tar_destroy() on the cloud Performance of tar_delete(), tar_destroy(), and tar_prune() on the cloud Nov 7, 2023
@wlandau
Copy link
Collaborator Author

wlandau commented Nov 7, 2023

Implemented for AWS S3! The GCP/GCS case depends on cloudyr/googleCloudStorageR#188.

@wlandau
Copy link
Collaborator Author

wlandau commented Dec 4, 2023

Going to close this one unless cloudyr/googleCloudStorageR#188 provides a way to do batched deletion in GCP.

@wlandau wlandau closed this as completed Dec 4, 2023
@wlandau wlandau reopened this Dec 4, 2023
@wlandau wlandau closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant