Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for dev tidyselect #928

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Fix for dev tidyselect #928

merged 1 commit into from
Sep 16, 2022

Conversation

hadley
Copy link
Member

@hadley hadley commented Sep 16, 2022

Since all_of() now always checks the variables even when strict = FALSE.

Since all_of() now always checks the variables even when `strict = FALSE`.
@wlandau
Copy link
Member

wlandau commented Sep 16, 2022

Thanks, @hadley.

targets 0.3.14 just landed on CRAN yesterday, sorry about the release timing.

@wlandau wlandau merged commit d085d70 into ropensci:main Sep 16, 2022
@hadley
Copy link
Member Author

hadley commented Sep 16, 2022

It'll probably be a week or two before I formally start the tidyselect release process so there should be time.

@hadley
Copy link
Member Author

hadley commented Sep 26, 2022

Just a note that I'm starting the release process for tidyselect with the goal of submitting to CRAN in two weeks, on October 10.

@wlandau
Copy link
Member

wlandau commented Sep 26, 2022

Thanks for the heads up, I just submitted an updated {targets} to CRAN.

(I mentioned the tidyselect submission date and that I will be out of office from tomorrow through Oct 14, so hopefully they won't mind that the last update was only a week and a half ago.)

@wlandau
Copy link
Member

wlandau commented Sep 26, 2022

The CRAN auto-check service just accepted it with no fuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants