RNG precautions #1168
Merged
RNG precautions #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prework
Related GitHub issues and pull requests
Summary
This PR implements and exports
tar_seed_create()to create target-specific seeds, and it uses SHA512 as an additional precaution against overlapping RNG streams. Justification of howtargetstreats random numbers is now in a new "RNG overlap" section oftar_seed_create().Thanks @shikokuchuo for the insight in #1139.
Unfortunately, these changes will invalidate all currently built targets because the seeds will be different. To avoid rerunning your whole pipeline, set
cue = tar_cue(seed = FALSE)intar_target().