-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCP integrations #748
GCP integrations #748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you so much @MarkEdmondson1234! My comments are minor, those and the lints are the only issues.
Thanks for feedback! Have put them in |
Thanks, Mark. Would you regenerate the Rd files? I think that will fix the checks. |
Sorry, one more thing I forgot: would you add a |
Test added, but only one since the other AWS ones didn't apply (part size and region) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Prework
Related GitHub issues and pull requests
Summary
Implementing
tar_resources_gcp
as specced in #720 (comment)