Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP integrations #748

Merged
merged 6 commits into from
Jan 19, 2022
Merged

GCP integrations #748

merged 6 commits into from
Jan 19, 2022

Conversation

MarkEdmondson1234
Copy link
Contributor

Prework

Related GitHub issues and pull requests

Summary

Implementing tar_resources_gcp as specced in #720 (comment)

Copy link
Collaborator

@wlandau wlandau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you so much @MarkEdmondson1234! My comments are minor, those and the lints are the only issues.

R/class_resources_gcp.R Show resolved Hide resolved
R/tar_resources_gcp.R Outdated Show resolved Hide resolved
R/tar_resources_gcp.R Show resolved Hide resolved
@MarkEdmondson1234
Copy link
Contributor Author

Thanks for feedback! Have put them in

@wlandau
Copy link
Collaborator

wlandau commented Jan 17, 2022

Thanks, Mark. Would you regenerate the Rd files? I think that will fix the checks.

@wlandau
Copy link
Collaborator

wlandau commented Jan 17, 2022

Sorry, one more thing I forgot: would you add a tests/testthat/test-tar_resources_gcp.R file much like the existing tests/testthat/test-tar_resources_aws.R? That should restore full code coverage.

@MarkEdmondson1234
Copy link
Contributor Author

Test added, but only one since the other AWS ones didn't apply (part size and region)

Copy link
Collaborator

@wlandau wlandau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@wlandau wlandau merged commit 82fa03a into ropensci:main Jan 19, 2022
@wlandau wlandau mentioned this pull request Mar 15, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants