We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running
tax_name(query = 'Galagoides demidovii', get = "family", db = "itis")
Results in
Retrieving data for taxon 'Galagoides demidovii' Error in tt$rank : $ operator is invalid for atomic vectors
Tried looking into how tax_name() works and it seems that the problem is when classification() returns not an NA, but this:
> classification(get_tsn('Galagoides demidovii', verbose=TRUE), verbose=verbose) Retrieving data for taxon 'Galagoides demidovii' $`944094` [1] NA attr(,"class") [1] "classification" attr(,"db") [1] "itis"
get_tsn() doesn't return an NA:
> tsn <- get_tsn( 'Galagoides demidovii', searchtype = "scientific", verbose = TRUE) Retrieving data for taxon 'Galagoides demidovii' > tsn [1] "944094" attr(,"match") [1] "found" attr(,"multiple_matches") [1] TRUE attr(,"pattern_match") [1] TRUE attr(,"uri") [1] "http://www.itis.gov/servlet/SingleRpt/SingleRpt?search_topic=TSN&search_value=944094" attr(,"class") [1] "tsn" > is.na(tsn) [1] FALSE
So the check here doesn't see it as an NA. Seems to be an issue with what ITIS returns for this species.
The text was updated successfully, but these errors were encountered:
thanks, @ljvillanueva what version of taxize and R do you have
Sorry, something went wrong.
looks like that taxon is invalid http://www.itis.gov/servlet/SingleRpt/SingleRpt?search_topic=TSN&search_value=944094
and the api call that classification(get_tsn('Galagoides demidovii')) makes is http://www.itis.gov/ITISWebService/services/ITISWebService/services/ITISService/getFullHierarchyFromTSN?tsn=944094
classification(get_tsn('Galagoides demidovii'))
which returns no taxonomic classification data
so we should handle that better, and not fail when no classification data returned
I'm using taxize 0.7.9 in R 3.2.3.
40b6002
@ljvillanueva reinstall and try again, should be fixed now
Yep, seems to be fixed now. Thanks!
great
No branches or pull requests
Running
Results in
Tried looking into how tax_name() works and it seems that the problem is when classification() returns not an NA, but this:
get_tsn() doesn't return an NA:
So the check here doesn't see it as an NA. Seems to be an issue with what ITIS returns for this species.
The text was updated successfully, but these errors were encountered: