changes output of ncbi_children when there are no children #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no children for a given taxon,
NULL
was being returned. This is fine whenout_type = "uid"
, senselength(NULL)
=0
so something likesapply(ncbi_children_output, length)
will give the expected results. However, ifout_type = "summary"
and a list of data.frames are the expected output,sapply(ncbi_children_output, nrow)
will haveNULL
s where 0 would logically be. I changed it so that whenout_type = "summary"
, taxa with no children are represented by adata.frame
with no rows, thus producing the expected result.